[rjwills28]

This PR contains the changes required to detect disconnections in the archive appliance raw and optimizedWithLastSample data, which will subsequently be plotted in the data browser with vertical dashed line and a gap until the PV reconnects:

It follows the change made for CS-Studio: ControlSystemStudio/cs-studio#2713.

Note:

• Currently this will only work for the 'OptimizedWithLastSample' post processing algorithm, which was recently updated in the AA to better represent the disconnects in the data: Show PV disconnections in the data browser cs-studio#2713. In this case we look for a connectionChange flag to indicate there was a disconnect and check for empty bins (due to there being no data).
• The Optimized post processor will set the connectionChange flag when there is a disconnect, but if a bin then has no events (due to the disconnect or because the PV was no changing) it will simply make a copy of the last bin with events and return that, meaning that there is no way to detect exactly when the disconnect occurred without some significant changes to the Optimized code in the AA.

OptimizedWithLastSample is now the default PP in Phoebus and in general is just better representation of the data so should always be used, hence in most cases we will see the disconnects. If Optimized is used then nothing will break but it will just not be able plot the disconnects.

Checklist

• Testing:

  • The feature has automated tests
  • Tests were run
  • If not, explain how you tested your changes

• Documentation:

  • The feature is documented
  • The documentation is up to date
  • Release notes:
    • Added an entry if the change is breaking or significant
    • Added an entry when adding a new feature

[sonarqubecloud]

Quality Gate failed

Failed conditions
18.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud