Repository navigation
Keep ambiguous cross-app routing on the default Bot - #920
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
When separate named apps have different unique Bot holders, do not let roster order choose which Bot owns the conversation. Preserve a single unique holder and confident model decisions. AI assistance: implemented and locally validated with OpenAI Codex; maintainer review remains required.
rudycelekli
requested review from
MikeRyanDev,
davidmckayv,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
October 31, 2026 03:29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
When an untagged message names Slack and Google Drive, and different Bots uniquely hold those apps, an uncertain router currently chooses whichever app appears first in the roster. That pins the conversation to one Bot without resolving the competing matches.
The fallback now keeps the default Bot when unique app matches point to different Bots. A single Bot uniquely holding both apps still wins, and a confident model decision remains unchanged. The regression exercises both roster orders and the single-holder control.
Where it runs
Boundary and audit
undecidedcause are preserved.Changelog
Proof
Base:
743649efc3f21d7bf0badbe6af2bcd5daedd97ce. Tested head:d428f669f10e21700b6d5eb1fb14e90c9cc59cfe.slack-botselected instead of the default).bun run format:check,bun run lint,bun run typecheck,bun run build, andgit diff --check: passed using pinned Bun 1.4.3.bun run test:ci: not green locally: 11,017 passed, 210 skipped, 2 failed across 886 files. The failures were the Recorder service-worker timing test and the routine-sweep concurrency test. Both failed test files and their production code are unchanged by this PR. Each case passed in isolation on both unchanged main and this head, with fresh dedicated test databases. Full-run/order causality remains unresolved; those targeted passes do not replace a green full-suite run.AI assistance: this change was implemented and locally validated with OpenAI Codex, then independently reviewed against the exact commit. Maintainer approval and hosted CI remain required.