Repository navigation
Store shape dispersion per component - #436
Draft
cailmdaley wants to merge 2 commits into
Draft
cailmdaley wants to merge 2 commits into
cailmdaley wants to merge 2 commits into
Conversation
Preserve existing OneCovariance inputs, including the two legacy catalogues with unverified original conventions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store covariance shape dispersion per component and remove the OneCovariance boundary division.
Closes #421.
cat_config, effective survey stats, OneCovariance inisigma_eps, GLASS config and diagnosticscratch/guerriniscriptsplot_comparison.pyis per component;exploration.pydivides its per-component noise power by an extra 2The exploratory scratch calculation is unchanged; it is not the workflow noise path.
DES
0.29andSP_axel_v0.00.30have no established provenance in the old config.Gatti et al. quote 0.261 for the DES Y3 catalogue, not 0.29.
Both legacy entries preserve their previous OneCovariance inputs rather than assume a convention; their physical values need verification.
The regression test checks the actual OneCovariance parameter function and noise term for SP, DES, and Axel, plus the conversion back to a summed-component CosmoCov input; 4 passed.
Ruff passed in the container.
Fast suite: 529 passed, 4 failed; develop: 525 passed, the same 4 failed (configured paths/column-gap checks and two temporary-directory cleanup errors).
PR #432 also changes
workflow/rules/covariance.smk; this PR only changes the parameter conversion there.— OpenAI on behalf of Cail.
🤖 Generated with Claude Code