Repository navigation
Conversation
When analyzing a target interpreter, the path-detection subprocess honored parent PYTHON* variables (notably PYTHONPATH), so packages visible only to the caller could appear in the SBOM. Add opt-in --isolated, which probes the target with python -E (same pattern as existing -S). Default behavior is unchanged. Prefer -E over -I so user-site packages remain discoverable. The flag only applies when a target <python> is given. Signed-off-by: Julio César Suástegui <juliosuas@users.noreply.github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | ✅ 0 (≤ 20 complexity) |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Documentation build overview
|
--isolated to ignore parent PYTHONPATH
|
i think the option lets better go with |
--isolated suggested a pip-like mode. Use short option -E, matching python -E and the existing -S flag (no long form). Behavior is unchanged: when -E is set and a target python is given, path detection probes with python -E so PYTHON* variables are ignored. Signed-off-by: Julio César Suástegui <juliosuas@users.noreply.github.com> Co-authored-by: Julio César Suástegui <juliosuas@users.noreply.github.com>
--isolated to ignore parent PYTHONPATH|
Done in c37f2cb: renamed to |
|
there popped up an alternative implementation for this feature: Originally, I planned to merge this one this week, since no new things popped up here. I tend to prefer this #1106 over the other/newer one. @juliosuas , @EltonChang1 , |
|
Thanks for the approval, @jkowalleck! I reviewed #1123 and left my notes there, proposing we land this one and add Elton's no-target idea as a credited follow-up. Lint is fixed in b73c19b; the macOS failures match the current |
Description
Fixes #1045.
cyclonedx-py environment <python>discovers the target interpreter'ssys.pathvia a subprocess. That subprocess previously honored parentPYTHON*variables (notablyPYTHONPATH), so packages visible only to the caller could appear in the SBOM as if installed in the scanned environment.Maintainers confirmed that inheriting the parent environment is intentional for some workflows and asked for an opt-in flag rather than changing the default.
This change adds
-E, which probes the target interpreter withpython -E(same insertion pattern as existing-S) soPYTHON*variables are ignored by the documented interpreter mechanism. Default behavior is unchanged. The flag only applies when a target<python>is given.Regression covered by
TestCliEnvironment.test_E_ignores_parent_pythonpath.Resolves or fixes issue:
#1045AI Tool Disclosure
[Cursor agent][Cursor agent (model not recorded); drafting only; every line human-reviewed][Implement opt-in --isolated for environment path detection per issue #1045 and maintainer guidance (use python -E; keep default inheritance; add regression test and docs); human-reviewed before opening]Affirmation