Repository navigation
Next - #177
Merged
Merged
Next#177
Conversation
- fix the intro that promised a property list the page lacks - fix the confirm section: dhx.confirm() returns the Promise - name dhx.message/alert/confirm/tooltip() in config intros - unify the four property-list notes, drop "here" link labels - backticks for API names, rework the smart positioning text - tense, articles, passive voice, and list punctuation fixes
- rename the third step heading, keep its anchor via explicit id - backticks for file names, the container id, and tooltip params - say paths instead of full paths to match the relative sample - rework the list intros so they end with colons - em dashes and colons in the constructor list - articles, possessives, and wordiness fixes in the steps - descriptive link label in the Configuration properties section
- rename gerund headings, keep their anchors via explicit ids - split the add-classes step, move the stylesheet note out of parentheses - list message, alert, confirm boxes and tooltip with or, not parentheses - backticks for the css property and the style element - articles, capitalized list items, built-in instead of own classes
- rewrite section intros to the "you will learn" pattern - align template rows (Optimus, AwaitRedraw, CSS classes) with Combobox - use "Learn how to" and "The example shows how to" consistently - fix the broken deep-dive idiom and the API reference intro - add the article to the message box heading, keep its anchor - article fixes for Message, HTML content, and the Optimus row
- split the 60-word intro sentence into a list of message types - map each type (message, confirm, alert, tooltip) to its purpose - drop filler words: tiny but useful, simply, some, certain
- name each box type instead of "this type of message box" - complete the message box fragment, fix articles in every section - list tooltip as a message type, not a separate component - replace marketing wording in the intro, website spelling
- format inputWidth, page and pageSize link labels as code - replace passive, "via" and "with the help of" with direct verbs - state that page takes a zero-based index, drop "attribute" - fix articles, put default values 0 and 10 in backticks
- rename Styling heading, keep the #styling anchor - capitalize list items, split the long first step - format css and <style> as code - replace "there is a possibility" and padded step intro
- fix intro naming DHTMLX Message instead of Pagination - unify section intros as "In this section you will learn" - replace passive "should be displayed" with active wording - align Optimus, CSS classes and AwaitRedraw rows with other components - fix articles and "which" clauses, list punctuation
- replace marketing wording with a description of the navigation bar - complete the list of supported data components - give the Guides intro a subject and a colon before the list - fix article, sentence case in API reference heading
- format events.on(), detach() and fire() as code instead of bold - lead detach and fire sections with the method name - say detach() removes listeners, not events - rename list heading, keep the #the-list-of-events anchor
- format file names, constructor and container ids as code - replace e.g., capitalize list items, end parameters with periods - drop "full" before paths, the samples use relative paths - replace passive and "here" link text, merge properties paragraph
- turn gerund headings into verb phrases, keep old anchors - replace i.e., via, by using/applying with direct method phrases - add missing articles, drop passive and future tense - use "number of items" consistently, format getPageSize() as code
[update] grammar and style in Message guides
[update] grammar and style in Pagination guides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.