Repository navigation
perf: run only affected Go packages with a safe full-suite fallback (#185) - #215
Merged
Merged
Conversation
…185) A Formula baseline check or an evaluation-plan check may declare select: affected-packages. Verification then runs go test only for the packages whose reverse-dependency closure (incl. test-only imports) contains a changed package, and falls back to the full suite on any uncertainty: non-Go or module files, nested modules, go list or git errors, Formula fullSuiteTriggers (default lab/cmd/**), too many packages or an argv over 128 KiB. Selection is refused when argv carries graph-affecting flags (-tags, -mod, -modfile, -overlay, -C, unknown), the analysis can never set it, approval requires the plan's triggers to match the Formula, and the independent evaluation verification always runs the full plan argv. The ledger records what was selected and why. Built by Forgecell Molecule mol-185-61e1d66f250ce58b35eb20cc (v3 Lab) with one review round and a verification pass. Hand-delivered: the protected run fails only the base cohort flake test whose fixture this slice intentionally changes; the full suite passes in a clean shell on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #185.
What it does.
select: affected-packages. Verification then runsgo testonly for packages whose reverse-dependency closure, including test-only and external-test imports, contains a changed package.go.mod/go.sum/go.work);go listor git returns an error, or the call times out;fullSuiteTriggers(defaultlab/cmd/**);-tags,-mod,-modfile,-overlay,-C, or any unknown flag.select.selecton checks the Formula didn't declare.Correctkeeps its meaning.Verification.
Built by: Forgecell Molecule
mol-185-61e1d66f250ce58b35eb20cc.Review: one adversarial round and one verification pass. Both blocking correctness findings were fixed:
-tags, reproduced in a scratch module;select.One hardening item is tracked in Hardening: plan limits enforced too late (stranded Molecules) and the learn recurrence scan's 40 MB cap #209.
The cohort test: its fixture now imports
calcso the flaky package stays selected. That keeps the test's meaning.Onboarding regression: the full-suite baseline also caught a regression where onboarding's bootstrap Formula failed the new validation. It's fixed.
Hand-delivered. The protected run fails only the base cohort flake test whose fixture this slice intentionally changes.
Clean suite: passes in a clean shell on current
main, 20 of 20 packages.🤖 Generated with Claude Code