Repository navigation
test: make wall-clock-dependent molecule/harness/process tests deterministic (#220) - #226
Merged
Merged
Conversation
…inistic (#220) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220.
This is a test-only change across
molecule,harness,processandcli. No production file changes, and every shipped default is untouched.cancelWhenStartedhelper cancels a run only after the stub has written its "started" marker. Interruption tests no longer race a 10 s watchdog, and a stub that never starts fails explicitly.process:expireOnMarkerandmarkedShelllet tests that need output and then a timeout expire only after the output provably exists. Silent-stall tests still wait out a realstallTimeout, because there the deadline is the behavior under test.successBackstopinstead of a 10–30 s budget. That replaces the 10 s budget inTestNativeBindingPassesAllowlistToClaudeArgvand the 30 s budgets inanalysis_correction_test.go. The shared run fixture's check timeout goes from 5 s to 120 s.TestHarnessTimeoutPlanValueIsHonouredAndRecorded: the control run now uses a stub that never finishes, so it still proves the Formula timeout fires. The plan-extended run gets minutes of headroom over its 11 s harness, and the test asserts that headroom.Built by Forgecell Molecule
mol-220-05bba754ffa48566e90b815a(plan revision 2 added the three extra flaky files the coder found). On the candidate tree, the load acceptancego test -count=5 -p 8 ./internal/molecule/... ./internal/harness/... ./internal/process/...passed, along with the 10× repeat of the three named tests, the cli/install packages and the shipped-default assertions.Hand-delivered: the Lab's full-suite baseline failed only on Go's 10-minute timeout in the unrelated
cliandevaluationpackages, which #222/#224 plus the Formula refresh address. Rebased ontomain(1f57972), an uncached clean-shellgo test -count=1 -timeout 25m ./...passes, and gofmt and vet are clean.🤖 Generated with Claude Code