Skip to content

Add convetion for netty-concurrent tests - #12956

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
andrea.marziali/fix-netty-test-cleanup-convention
Oct 20, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
andrea.marziali/fix-netty-test-cleanup-convention

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

Add an opt-in dd-trace-java.instrumentation.netty-concurrent-tests convention under build-logic/conventions. It supplies the Netty task activation and cleanup instrumentation paired with java-concurrent.

Also add the convention that was missing to opensearch/elasticsearch modules that require that for testing

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali
amarziali requested a review from bric3 October 20, 2026 10:05
@amarziali
amarziali requested review from a team as code owners October 20, 2026 10:05
@amarziali amarziali added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Oct 20, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T10:09:53.756323Z 4f6c86c PR opened
🔒 Security Review ✅ Completed 2026-10-20T10:09:41.068109Z 4f6c86c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-4 datadog-prod-us1-4 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The convention preserves existing Netty test dependencies, including inheritance by additional test suites, and supplies the missing cleanup instrumentation to Elasticsearch and OpenSearch modules. Static review identified no actionable correctness issues.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 4f6c86c

@bric3 bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but the modified doc file should be updated.

I'd like "alert" on avoiding referring to projects from within the build logic folders, but it's not a hard rule either.

Comment thread docs/how_to_work_with_gradle.md Outdated
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.85% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b8cd360 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.80 s 14.66 s [+0.2%; +1.7%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.56 s 13.65 s [-1.3%; +0.0%] (no difference)
startup:petclinic:appsec:Agent 17.08 s 17.02 s [-0.6%; +1.3%] (no difference)
startup:petclinic:iast:Agent 16.82 s 17.06 s [-2.4%; -0.5%] (maybe better)
startup:petclinic:profiling:Agent 16.62 s 16.87 s [-2.6%; -0.4%] (maybe better)
startup:petclinic:sca:Agent 17.01 s 16.92 s [-0.3%; +1.4%] (no difference)
startup:petclinic:tracing:Agent 16.05 s 16.27 s [-2.3%; -0.4%] (maybe better)

Commit: b8cd3607 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Comment thread docs/how_to_work_with_gradle.md
@amarziali
amarziali enabled auto-merge October 20, 2026 12:17
@amarziali
amarziali added this pull request to the merge queue Oct 20, 2026
@dd-octo-sts

dd-octo-sts Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-20 12:44:41 UTC ℹ️ Start processing command /merge


2026-10-20 12:44:46 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-10-20 13:44:59 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 20, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 6e221f3 into master Oct 20, 2026
822 of 824 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/fix-netty-test-cleanup-convention branch October 20, 2026 13:44
@github-actions github-actions Bot added this to the 1.68.0 milestone Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants