Repository navigation
Add convetion for netty-concurrent tests - #12956
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The convention preserves existing Netty test dependencies, including inheritance by additional test suites, and supplies the missing cleanup instrumentation to Elasticsearch and OpenSearch modules. Static review identified no actionable correctness issues.
🤖 Bits Code Review · Commit 4f6c86c
bric3
left a comment
There was a problem hiding this comment.
OK, but the modified doc file should be updated.
I'd like "alert" on avoiding referring to projects from within the build logic folders, but it's not a hard rule either.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
6e221f3
into
master
What Does This Do
Add an opt-in dd-trace-java.instrumentation.netty-concurrent-tests convention under build-logic/conventions. It supplies the Netty task activation and cleanup instrumentation paired with java-concurrent.
Also add the convention that was missing to opensearch/elasticsearch modules that require that for testing
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]