Repository navigation
Conversation
Eager post-processors run on the application thread as a span finishes. They now take a SpanContents (read/write facets over a span's tags) instead of a TagMap, and DDSpanContext implements SpanContents directly, so no TagMap view needs to be built for them once span storage stops being a single TagMap. This is the first slice: only getObject/getString/set. Writes bypass interception; thread safety is left to each implementation (DDSpanContext's methods are unsynchronized, called under the tag lock). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 23, 2026
This comment has been minimized.
This comment has been minimized.
Contributor
🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Introduces
SpanContents, a read/write interface over a span's tags. The eager tag post-processors now run against it instead of aTagMap.SpanContentsextends two facets:ReadableSpanContents(getObject,getString) andWritableSpanContents(set(tag, value),set(EntryReader)). Writes go straight to storage, with no interception.DDSpanContextimplementsSpanContents. Its four methods are unsynchronized, likeunsafeGetTag, because callers already hold the span's tag lock, asearlyProcessTagsdoes.TagMapimplementsSpanContentstoo, so standalone maps and tests can be passed directly.EagerTagsPostProcessor, which takes aSpanContents. They arePeerServiceCalculator,InternalTagsAdderandHttpEndpointPostProcessor, chained byEagerPostProcessorChain.NamingSchema.ForPeerServiceandEndpointResolvertake the same interface.This is the first slice: only what the eager processors need. Name and id variants, primitive setters and typed getters come as more readers and writers move over.
Motivation
The eager post-processors run on the application thread as a span finishes. Once a span's tags are no longer one
TagMap(see the split PR in the stack), handing them aTagMapmeans building a view per span on the application thread. In that PR the view cost +4–5% per trace. WithSpanContents, the span passes itself, and nothing is allocated.Additional Notes
DDSpanContextandDDSpansuites.EndpointResolverTestnow usesTagMapinstead ofHashMap.Where this is going
This PR is one step in replacing the span's single
TagMapwith storage that knows each tag's kind. The goal is to cut what every span allocates on the application thread, without changing behavior.The end state
TagMapbecomes a thin view for code outside the span.Entryobject per tag, and each span's store is presized from a per-operation hint. With the flag on, a web-request-shaped trace allocates about 30% less on the application thread than on master.SpanContents, not aTagMap. That covers post-processors now and serializers later, so noTagMapview gets built for them.SpanContentsstarts with four methods and grows a name, id and primitive API as more readers move to it.Later, not in this stack: cheaper read-through to parent spans, trace-level tags in a per-trace holder (
TraceSegment), and primitive tag values without boxing.The stack. This replaces #12918, split into pieces that can each be reviewed, and measured, on their own.
TagMap. This is the stack's only behavior change, kept separate on purpose.TagMap, and addTraceShapeBenchmarkSpanContentsfor the eager post-processorsTagMap's bucket mechanics intoHashSupport(a pure move)TagMapa facade over the two storestrace.experimental.dense.tags.enabled(off by default)Every PR after #12999 is behavior-preserving.
The pieces' allocation figures come from a deterministic per-thread probe (
ThreadMXBeanallocated bytes) that builds the same 7-span trace asTraceShapeBenchmark. The #12992 and #12926 figures come fromTraceShapeBenchmarkitself.🤖 Generated with Claude Code