Skip to content

ci: test the oracle marker check only when it changes - #2167

Merged
Benoît Cortier (CBenoit) merged 1 commit into
masterfrom
ci/oracle-marker-tests-on-change
Oct 27, 2026
Merged

Benoît Cortier (CBenoit) merged 1 commit into
masterfrom
ci/oracle-marker-tests-on-change

Conversation

@irvingoujAtDevolution

Copy link
Copy Markdown
Contributor

The oracle marker check tests install Pester from PSGallery, and that download fails at times, failing CI for commits that never touched the check.

The tests now run only when the commit changes the check or its tests, compared with the commit's first parent, which for a pull request is its base branch. Manual and release runs still run them every time. The steps are skipped rather than the job, because the success job requires every job to succeed.

Co-authored-by: Claude Opus 5.5 noreply@anthropic.com

The oracle marker check tests install Pester from PSGallery, and that
download fails at times, failing CI for commits that never touched the
check.

The tests now run only when the commit changes the check or its tests,
compared with the commit's first parent, which for a pull request is
its base branch. Manual and release runs still run them every time.
The steps are skipped rather than the job, because the success job
requires every job to succeed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 27, 2026 14:53
@github-actions

Copy link
Copy Markdown

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow CI change matches the stated behavior, preserves required-job handling, and has no unresolved findings.

No open issues 🎉

What changed in this PR

This PR reduces unrelated CI failures from PSGallery downloads by running the oracle marker check tests only when relevant files change.

Changes:

  • Fetches two commits to compare the checked-out commit with its first parent.
  • Gates Pester installation and tests on changes to the check or its tests, while retaining unconditional manual and release runs.
  • Skips individual steps rather than the job, preserving required-job success handling.
File Description
.github/​workflows/​ci.yml Adds change detection and conditional execution for the oracle marker check tests.

Review effort: Balanced

@irvingoujAtDevolution

Copy link
Copy Markdown
Contributor Author

Lines changed, against master:

Added Removed
Production code 0 0
Tests 0 0
Other (CI) 22 0

The whole change is in .github/workflows/ci.yml.

Note

LLM-assisted content (no human feedback).

@CBenoit Benoît Cortier (CBenoit) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@CBenoit
Benoît Cortier (CBenoit) merged commit 47c995c into master Oct 27, 2026
55 checks passed
@CBenoit
Benoît Cortier (CBenoit) deleted the ci/oracle-marker-tests-on-change branch October 27, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants