Repository navigation
dstack-util: keep the gateway token stable for half an hour - #1499
Merged
Merged
Conversation
Every registration minted a new token, so the instance record changed every three minutes even when nothing else did. Round iat down to the half hour and expire an hour later: Ed25519 signatures are deterministic, so registrations within one period send the same token, and it always has at least 30 minutes left. This does not yet reduce gateway writes, which happen on every registration regardless; it makes the record stable so a later skip-if-unchanged in the gateway can. Signed-off-by: Kevin Wang <wy721@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1469. Every registration minted a new agent token, so the gateway's instance record changed every three minutes even when nothing else did.
Round
iatdown to the half hour and setexpan hour later. Ed25519 signatures are deterministic, so registrations within one period carry the same token, and it always has at least 30 minutes left (vs. 10 before).This does not yet reduce gateway writes, which happen on every registration regardless; it makes the record stable so a later skip-if-unchanged in the gateway can.