Repository navigation
Conversation
ocaisa
requested changes
Oct 28, 2026
ocaisa
reviewed
Oct 28, 2026
Member
|
@Flamefire Conflict here to resolve now, but perhaps better to wait for #322 . Maybe next time it would have been better to couple the 3 PRs to this file together into a single PR. The need to deploy them means that we have to be very careful to keep the branches up-to-date so what is actually deployed represents what is currently in the repository. |
When an exported EASYBUILD_ variable is misspelled `eb` invocations will fail. As no logfile is created this results in a `cp -a .` creating another error message. Check each `eb` invocation and report errors on failure. Also switch from using `$ret` for return code checking to plain `if` to avoid missing a check.
The `-o pipefail` may cause an exit code from `module` to trigger the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an exported EASYBUILD_ variable is misspelled
ebinvocations will fail. As no logfile is created this results in acp -a .creating another error message.Check each
ebinvocation and report errors on failure. Also switch from using$retfor return code checking to plainifto avoid missing a check.I ran into this when setting
EASYBUILD_BUILD_DIR, extra underscore.Note the
ret=$?which is never checked for