Repository navigation
[documentation]: document while tactic - #880
Merged
Merged
Conversation
fdupress
marked this pull request as ready for review
March 20, 2026 14:43
fdupress
marked this pull request as draft
March 20, 2026 14:45
Member
|
@oskgo to remove uncertain parts, then merge despite being incomplete. |
Contributor
|
The pHL while documentation is out of sync with the implementation due to the recent (and upcoming) soundness fixes. Ideally we'd check the documentation examples in CI (maybe we already do this?), which would give us a signal to fix the documentation when making breaking changes. For now I'm keeping the examples but removing the text around them which is likely wrong. We could also ask the PRs making the breaking changes to update the documentation, but that requires this to be merged first. If we merge as-is I'd like to keep the last commit separate from the rest so we preserve the removed text in git history somewhere. |
Co-Authored-By: Oskar Goldhahn <oskar.goldhahn@ntnu.no>
fdupress
force-pushed
the
doc-while-tactic
branch
from
October 30, 2026 14:45
d865701 to
5ae340a
Compare
fdupress
marked this pull request as ready for review
October 30, 2026 15:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.