Repository navigation
Start/stop the CI k8s sandbox for regional sandbox labels too, per listed region (ENG-221179) - #37
Open
asheth-eightfold wants to merge 1 commit into
Open
asheth-eightfold wants to merge 1 commit into
asheth-eightfold wants to merge 1 commit into
Conversation
…sted region (ENG-221179) needs_sandbox:<region> and stop_sandbox now also dispatch sandbox.yml for the regional labels (sandbox 🇪🇺, 🍁, 🏛️, 🇦🇪, 🇺🇸, 🇦🇺), passing the region as the needs_sandbox suffix (eu, ca, gov, uae, wu, ap). A region is dispatched only when it is listed in SANDBOX_K8S_REGIONS, set by the calling workflow, so a region joins CI k8s by being listed there. The plain `sandbox` dispatch is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #36. That PR dispatches EightfoldAI/vscode's
sandbox.ymlonly for the plainsandboxlabel. This one does the same for the regional sandbox labels, soneeds_sandbox:ap(and later:eu,:ca, …) can start and stop a CI k8s sandbox in that region.sandbox_k8s_request <start|stop> [region]: a region is passed as theneeds_sandboxsuffix (eu,ca,gov,uae,wu,ap) in the dispatch'sregioninput.needs_sandbox:<region>and ofstop_sandboxcalls it with its region.SANDBOX_K8S_REGIONS. The calling workflow (vscode'scomment_actions.yml) sets it from a repo variable, space- or comma-separated. A region joins CI k8s by being listed there, with no change in this repo.sandboxdispatch: same payload, noregionkey;SANDBOX_K8S_TRIGGERisn't"true";SANDBOX_K8S_TRIGGERSANDBOX_K8S_REGIONSstart(US){"pr","action":"start"}, as #36start apapstart ap/stop ap…,"region":"ap"apstart euap,eu/ap eustart eu…,"region":"eu"(ca: nothing)apThe table was checked with the function sourced alone and
curl/jqstubbed (bash -nclean).Order
GitHub rejects a dispatch with an input the workflow doesn't define (HTTP 422;
|| truekeeps the action green). So:SANDBOX_K8S_REGIONSis set);sandbox.yml'sregioninput (us|ap) and passesSANDBOX_K8S_REGIONS(EightfoldAI/vscode, branchfeat/asheth/eng-221179, stacked on vscode#122623);vars.SANDBOX_K8S_REGIONS=apin vscode.JIRA: ENG-221179
🤖 Generated with Claude Code