Skip to content

Start/stop the CI k8s sandbox for regional sandbox labels too, per listed region (ENG-221179) - #37

Open
asheth-eightfold wants to merge 1 commit into
masterfrom
asheth/sandbox-k8s-regions
Open

asheth-eightfold wants to merge 1 commit into
masterfrom
asheth/sandbox-k8s-regions

Conversation

@asheth-eightfold

@asheth-eightfold asheth-eightfold commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #36. That PR dispatches EightfoldAI/vscode's sandbox.yml only for the plain sandbox label. This one does the same for the regional sandbox labels, so needs_sandbox:ap (and later :eu, :ca, …) can start and stop a CI k8s sandbox in that region.

  • sandbox_k8s_request <start|stop> [region]: a region is passed as the needs_sandbox suffix (eu, ca, gov, uae, wu, ap) in the dispatch's region input.
  • Every regional branch of needs_sandbox:<region> and of stop_sandbox calls it with its region.
  • A region is dispatched only if it is listed in SANDBOX_K8S_REGIONS. The calling workflow (vscode's comment_actions.yml) sets it from a repo variable, space- or comma-separated. A region joins CI k8s by being listed there, with no change in this repo.
  • Unchanged:
    • the plain sandbox dispatch: same payload, no region key;
    • everything when SANDBOX_K8S_TRIGGER isn't "true";
    • the labels themselves, which still go to the fleet as before.
SANDBOX_K8S_TRIGGER SANDBOX_K8S_REGIONS call dispatched
true empty start (US) {"pr","action":"start"}, as #36
true empty start ap nothing
true ap start ap / stop ap …,"region":"ap"
true ap start eu nothing
true ap,eu / ap eu start eu …,"region":"eu" (ca: nothing)
false ap any nothing

The table was checked with the function sourced alone and curl/jq stubbed (bash -n clean).

Order

GitHub rejects a dispatch with an input the workflow doesn't define (HTTP 422; || true keeps the action green). So:

  1. merge this (inert until SANDBOX_K8S_REGIONS is set);
  2. merge the vscode side, which adds sandbox.yml's region input (us|ap) and passes SANDBOX_K8S_REGIONS (EightfoldAI/vscode, branch feat/asheth/eng-221179, stacked on vscode#122623);
  3. set vars.SANDBOX_K8S_REGIONS=ap in vscode.

JIRA: ENG-221179

🤖 Generated with Claude Code

…sted region (ENG-221179)

needs_sandbox:<region> and stop_sandbox now also dispatch sandbox.yml for the
regional labels (sandbox 🇪🇺, 🍁, 🏛️,
🇦🇪, 🇺🇸, 🇦🇺), passing the region as the
needs_sandbox suffix (eu, ca, gov, uae, wu, ap). A region is dispatched only when
it is listed in SANDBOX_K8S_REGIONS, set by the calling workflow, so a region joins
CI k8s by being listed there. The plain `sandbox` dispatch is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant