Skip to content

tests: invariant checks for the LSPS client tests #9657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nepet wants to merge 6 commits into
base: master
Choose a base branch
from
Open

tests: invariant checks for the LSPS client tests #9657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bf4bb03
lsps-plugin: don't let the reduced JIT invoice outlive valid_until
nepet Oct 27, 2026
f22b6ec
tests: add amount and identity oracles for the LSPS2 client tests
nepet Oct 20, 2026
8f9be1d
tests: add the params and deadlines oracle for the LSPS2 client tests
nepet Oct 20, 2026
9518397
tests: add the robustness oracle for the LSPS2 client tests
nepet Oct 20, 2026
f8f9e32
tests: check extra_fee in the LSPS2 amount oracle
nepet Oct 20, 2026
220062b
tests: explain why the LSPS2 oracles have their own unit tests
nepet Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions plugins/lsps-plugin/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,8 @@ async fn on_lsps_lsps2_invoice(

// We define the invoice expiry here to avoid cloning `selected_params`
// as they are about to be moved to the `Lsps2BuyRequest`.
let expiry = (selected_params.valid_until.as_chrono() - Utc::now()).num_seconds();
let valid_until = selected_params.valid_until.as_chrono();
let expiry = (valid_until - Utc::now()).num_seconds();
if expiry <= 10 {
return Err(anyhow!(
"Invoice lifetime is too short, options are valid until: {}",
Expand Down Expand Up @@ -483,7 +484,9 @@ async fn on_lsps_lsps2_invoice(
dev_routes: Some(vec![vec![hint]]),
description: req.description,
label: req.label,
expiry: Some(expiry as u64),
// Not `expiry`: creating the public invoice took time,
// and this one must not outlive `valid_until` either.
expiry: Some((valid_until - Utc::now()).num_seconds().max(0) as u64),
cltv: None,
deschashonly: None,
preimage,
Expand Down
Loading
Loading