Repository navigation
fix(image): install lsof and tmux in the runner image - #144
Merged
Merged
Conversation
Jobs that need either tool installed it with apt on every run, because the image ships neither. A test that falls back to lsof where there is no /proc failed outright on the fleet until a workflow installed it.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 2.9.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds lsof and tmux to the runner image's apt install.
The image ships neither, so a workflow whose jobs need them installs both with apt on every run. One of those jobs runs a test that falls back to lsof where there is no /proc (it is what macOS uses), and that test fails on the fleet when lsof is missing. A job on a fleet runner printed "installing: tmux lsof" before the test passed.
This only changes the Dockerfile; the image has to be rebuilt and rolled out before jobs see it.