Repository navigation
Conversation
The node-cache example names the store with `pnpm_config_store_dir` and turns on the global virtual store through the environment, which is pnpm 11. pnpm 10 does not read `pnpm_config_*` variables, and it switches the global virtual store off whenever `CI` is set, so an Actions job on pnpm 10 gets the store only through `--store-dir` and imports from it by copying, because the store sits on another mount than the workspace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The node-cache pnpm example in the role README only works on pnpm 11. I tried it against pnpm 10.29.3:
pnpm_config_store_diris ignored, the store lands in the default location, andenableGlobalVirtualStoreis forced to false wheneverCIis set, which it always is in Actions. pnpm 11.19.0 only does that when the setting is not given explicitly. Read from the installedpnpm.cjsandpnpm.mjs, and confirmed with a real install underCI=true(virtualStoreDirstays.pnpm).So on pnpm 10 the store has to be named with
--store-dir, and since it sits on another mount from the workspace pnpm copies instead of linking. This adds that as a paragraph and a one-line step beside the existing example. Docs only; the example the unit test reads is untouched andDocumentedExampleTestpasses.