Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
DEFAULT_MAX_EVALUATION_NODES and DEFAULT_MAX_NESTING_DEPTH are what createEvaluator and createSyncEvaluator apply when maxNodes and maxNestingDepth are not given. Exporting them lets a caller check a tree against the same limits before evaluating it, rather than copying the numbers, which would drift when the defaults change.
combinatrix is an org-owned package released by its own semantic-release CI with trusted publishing, like the two packages already exempted, and the workspace is about to depend on it.
…n trees and cover them Adds packages/trilean-combinatorics, depending on trilean and on combinatrix. trileanConstraint turns a predicate tree given as JSON into a combinatrix Constraint. The tree is validated with PredicateNodeSchema and walked: node kinds the adapter has no resolver for (collections, lookup, delegate, treeReference), reference keys that are not strings or name no dimension, units on references, calls to unregistered functions and referenced domains holding null are all refused at definition time, and so is a tree larger or deeper than trilean's default evaluation budget. Evaluation uses the synchronous evaluator with an unassigned dimension resolved as not yet known and an unset one as known absent, so a definite answer on a partial assignment holds for every completion. An indeterminate result once every dependency is assigned throws UndecidedConstraintError instead of breaking the contract. coveringArray is a strategy yielding a covering array of strength t over the solution set: every t-tuple of values that some valid combination contains appears in a yielded row, built greedily and deterministically from the full solution set. isCoveringArray is the independent brute-force check, used as the oracle of property tests over seeded random models. The package is ESM only, as combinatrix is, and pins the first combinatrix version that will be published.
d6957b6 to
a4564ba
Compare
|
@codex security review |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
Adds packages/trilean-combinatorics: trileanConstraint turns a trilean predicate tree into a combinatrix Constraint (unassigned dimensions resolve as not yet known, unset ones as known absent, so a definite answer on a partial assignment holds on every completion), and coveringArray is a strategy yielding a t-wise covering array of a model's valid combinations, checked by property tests against an independent isCoveringArray oracle. It also exports trilean's default evaluation budgets so the adapter can refuse an oversized tree when the constraint is defined.
This stays a draft until combinatrix 1.0.0 is on npm: the package pins it, the registry only has a 0.0.0 placeholder, so
pnpm install --frozen-lockfilecannot pass yet and pnpm-lock.yaml is deliberately unchanged here. Once it is published,pnpm installregenerates the lockfile and that commit is the last thing this needs.