Repository navigation
feat(trilean-combinatorics): build covering arrays without materialising the solution set - #113
Conversation
d6957b6 to
a4564ba
Compare
960698f to
67dd53f
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
…ing the solution set coveringArray now uses an in-parameter-order construction (IPOG): rows start from the coverable t-tuples of the first t dimensions, each later dimension is placed by horizontal growth and then vertical growth, and every row is completed and redundant rows dropped at the end. Whether a tuple is coverable, and whether a row may take a value, are asked of the engine through the strategy context's completions, stopping at the first valid combination, so memory follows the number of t-tuples and not the solution set. limit is now optional and bounds the rows the construction holds, still refusing with combinatrix's LimitExceededError past it. The greedy construction over the whole solution set moves to the test support as the reference the new output is compared with. A work-count test bounds the engine queries on a model whose solution set is far larger than its tuple count.
67dd53f to
189905f
Compare
|
@codex security review |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
|
🎉 This PR is included in trilean-combinatorics@1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
coveringArray now builds the array in parameter order (IPOG), asking the engine through the strategy context's completions whether a valid combination agrees with a partial row and stopping at the first, so it never reads the solution set and its memory follows the number of t-tuples. The limit becomes optional and bounds the rows the construction holds. The old greedy construction stays in the test support as the reference: the new output is checked against isCoveringArray at strengths 1 to 3, compared with the reference's size over the generated models, and held to a bound on engine queries derived from the tuple count.
Fixes #112