Repository navigation
Conversation
install(FILES ...) expects files, so it works when cmake is called for the first time, but when the make was called and the doc/html exists, and is directory, subsequent call to cmake fails because target is not file any more. Change to DIRECTORY solves the problem as cmake installs now whole directory tree structure.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Add contributor CONTRIBUTORS |
The contributors list gains Lalik, Rafał with an ORCID profile link. |
Documentation installation
| Layer / File(s) | Summary |
|---|---|
Install generated HTML directory doxygen/CMakeLists.txt |
The install command uses the directory form. The destination and component remain unchanged. |
Priority:
Estimated code review effort: 1 (Trivial) | ~4 minutes
Merge Risk: 
90435
-
The changes are ready to merge; documentation installation now uses the appropriate directory form without an identified contract violation.
Pre-merge checks: 
-
Check name Status Explanation Title check The title names the change: the documentation install command in the build files is fixed. It matches the CMake change from install(FILES ...) to install(DIRECTORY ...) for the generated docs. The tit… Description check The description explains the problem. install(FILES ...) fails on repeated CMake runs after doc/html exists as a directory. Switching to DIRECTORY installs the whole tree. This matches the doxygen/CMa… Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the change: the documentation install command in the build files is fixed. It matches the CMake change from install(FILES ...) to install(DIRECTORY ...) for the generated docs. The title is concise and specific, though it does not say why the change is needed.
Full details: Description check
-
Explanation
The description explains the problem. install(FILES ...) fails on repeated CMake runs after doc/html exists as a directory. Switching to DIRECTORY installs the whole tree. This matches the doxygen/CMakeLists.txt change. The description is related to the changeset.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
install(FILES ...)expects files, so it works when cmake is called for the first time, but when the make was called and thedoc/htmlexists, and is directory, subsequent call to cmake fails because target is not file any more. Change toDIRECTORYsolves the problem as cmake installs now whole directory tree structure.