Repository navigation
Fix thoth consuming one extra op per iteration - #1352
Merged
Merged
Conversation
Robotgiggle
added
1.20
optimization
IridescentVoid
requested changes
Oct 22, 2026
IridescentVoid
left a comment
IridescentVoid
left a comment
Contributor
There was a problem hiding this comment.
Removing the op increment is fine, but there's a logic error in the code here. (This also needs a bit of extra attention when porting to 1.21 since thoth's behavior changes there.)
github-project-automation
Bot
moved this from 📋 Backlog
to 🏗 In progress
in Hex Casting
IridescentVoid
approved these changes
Oct 22, 2026
IridescentVoid
left a comment
IridescentVoid
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, but I'd prefer if another set of eyes could check over the logic too.
Member
Author
|
I just extensively tested all three potential cases (normal thoth, no-patterns thoth with empty stack, no-patterns thoth with other stuff on the stack) and everything worked exactly as expected, so I think this is good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1351. Also changes Thoth to automatically generate the output list and return it (without actually iterating) if the pattern list is empty, for efficiency purposes.