Repository navigation
Stacking upkeep cost for holding truenames in active spell circles - #1354
Open
Robotgiggle wants to merge 7 commits into
Open
Robotgiggle wants to merge 7 commits into
Robotgiggle wants to merge 7 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to #1299, it's now possible to hold any number of truenames on the stack of a looping circle indefinitely. This PR changes that by adding a steadily increasing upkeep cost for holding truenames in a circle (either on the stack or in the ravenmind). After 10 slates have been activated with a held truename, the next slate will consume 1 dust, then the one after that will consume 2 dust, and so on until there are no longer any truenames on the stack (or the circle runs out of media). Note that, as with Transgress Other, this does not apply to the circle's own caster.
The delay before the cost starts up is controllable in the server config, and it can also be set to -1 to completely disable this feature and allow indefinite truename-holding as before.
This PR also fixes #1201, since otherwise the lack-of-media mishap caused by the upkeep cost would produce no error message whatsoever on the impetus, which could be very confusing (especially for players who are familiar with spell circles but not with this new mechanic).