Repository navigation
ci: pin actionlint version and add pre-commit hook - #53
greenc-FNAL wants to merge 1 commit into
Conversation
- Pin the CI actionlint version to 1.7.12 for consistent linting. - Add a pre-commit hook that skips ShellCheck on Darwin, where actionlint can deadlock.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Actionlint version and pre-commit integration scripts/pre-commit/actionlint.sh, .pre-commit-config.yaml, .github/workflows/ci.yaml |
The wrapper disables ShellCheck integration on Darwin and forwards arguments to actionlint. The pre-commit hook invokes the wrapper, and the CI workflow pins actionlint to version 1.7.12. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Merge Risk: 
Minimal · up to f96a6
-
The actionlint integration is consistent across pre-commit and CI with no established merge-blocking risk.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the actionlint version alignment and macOS-specific ShellCheck workaround.
No open issues 🎉
What changed in this PR
This PR aligns local and CI workflow validation on actionlint 1.7.12 and adds a macOS-specific workaround for the reported ShellCheck pipe deadlock.
Changes:
- Pin the CI actionlint version to 1.7.12.
- Add the matching pre-commit hook with a wrapper that disables ShellCheck on Darwin while preserving it on Linux.
| File | Description |
|---|---|
scripts/pre-commit/actionlint.sh |
Wraps actionlint to skip ShellCheck on Darwin and forward supplied arguments. |
.pre-commit-config.yaml |
Adds the actionlint v1.7.12 hook using the wrapper. |
.github/workflows/ci.yaml |
Pins the actionlint executable version to 1.7.12. |
Review effort: Balanced
Summary
Dependencies
This PR contains one commit directly above
upstream/mainand changes only the CI workflow, pre-commit configuration, and actionlint wrapper. It is independent of the guardrail PR and can merge in either order.Validation
git diff --checkpassed.raven-actions/actionlintto version1.7.12.rhysd/actionlinthook atv1.7.12, using a wrapper script.git diff --checkpassed. Test results were not independently verified.