Skip to content

ci: pin actionlint version and add pre-commit hook - #53

Open
greenc-FNAL wants to merge 1 commit into
mainfrom
ci/pin-actionlint
Open

greenc-FNAL wants to merge 1 commit into
mainfrom
ci/pin-actionlint

Conversation

@greenc-FNAL

@greenc-FNAL greenc-FNAL commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Pin CI and pre-commit to actionlint 1.7.12 for consistent workflow validation.
  • Add the pinned actionlint pre-commit hook and a wrapper that skips ShellCheck on Darwin to avoid actionlint's pipe deadlock; Linux CI retains ShellCheck.
  • Preserve the existing actionlint commit without including the separate guardrail changes.

Dependencies

This PR contains one commit directly above upstream/main and changes only the CI workflow, pre-commit configuration, and actionlint wrapper. It is independent of the guardrail PR and can merge in either order.

Validation

  • Pre-commit checks passed for all three changed files before pushing.
  • The complete commit diff and branch tracking were inspected.
  • git diff --check passed.
  • CI: Pin raven-actions/actionlint to version 1.7.12.
  • Pre-commit: Add the rhysd/actionlint hook at v1.7.12, using a wrapper script.
  • Code quality: On Darwin, the wrapper disables ShellCheck to avoid an actionlint pipe deadlock. On other platforms, it passes the supplied arguments to actionlint unchanged. CI still runs actionlint on Linux.
  • Tests: The supplied context reports that pre-commit checks passed for all three changed files and git diff --check passed. Test results were not independently verified.

- Pin the CI actionlint version to 1.7.12 for consistent linting.
- Add a pre-commit hook that skips ShellCheck on Darwin, where actionlint can deadlock.
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 4c6abfda-c716-4236-ad9c-52b018968b2b
Commits

Reviewing files that changed from the base of the PR and between 53fe6d1 and f96a677.

Files selected for processing: 3
  • .github/workflows/ci.yaml
  • .pre-commit-config.yaml
  • scripts/pre-commit/actionlint.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Context from checks skipped due to timeout: 1
  • GitHub Check: setup
Additional context used
Code guidelines: 1
AGENTS.md — auto-discovered
Path-based instructions: 1
Source excerpt: YAML: formatted with prettier (120-char soft limit, 2-space indent).

CodeRabbit inference engine (AGENTS.md)

Files:

  • .github/workflows/ci.yaml
  • .pre-commit-config.yaml
Additional comments: 3
scripts/pre-commit/actionlint.sh: 1

1-9: LGTM!

.pre-commit-config.yaml: 1

50-55: LGTM!

.github/workflows/ci.yaml: 1

64-64: LGTM!

Walkthrough

The CI workflow now pins actionlint to version 1.7.12. A pre-commit hook uses the same version and runs through a wrapper that disables ShellCheck integration on Darwin.

Changes: Actionlint tooling

Layer / File(s) Summary
Actionlint version and pre-commit integration
scripts/pre-commit/actionlint.sh, .pre-commit-config.yaml, .github/workflows/ci.yaml
The wrapper disables ShellCheck integration on Darwin and forwards arguments to actionlint. The pre-commit hook invokes the wrapper, and the CI workflow pins actionlint to version 1.7.12.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to f96a6

The actionlint integration is consistent across pre-commit and CI with no established merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main changes: pinning the actionlint version and adding a pre-commit hook.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the actionlint version alignment and macOS-specific ShellCheck workaround.

No open issues 🎉

What changed in this PR

This PR aligns local and CI workflow validation on actionlint 1.7.12 and adds a macOS-specific workaround for the reported ShellCheck pipe deadlock.

Changes:

  • Pin the CI actionlint version to 1.7.12.
  • Add the matching pre-commit hook with a wrapper that disables ShellCheck on Darwin while preserving it on Linux.
File Description
scripts/​pre-commit/​actionlint.sh Wraps actionlint to skip ShellCheck on Darwin and forward supplied arguments.
.pre-commit-config.yaml Adds the actionlint v1.7.12 hook using the wrapper.
.github/​workflows/​ci.yaml Pins the actionlint executable version to 1.7.12.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants