Repository navigation
fix: represent absent and empty creator and suffix explicitly - #1009
Draft
marcpaterno wants to merge 2 commits into
Draft
marcpaterno wants to merge 2 commits into
marcpaterno wants to merge 2 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
marcpaterno
force-pushed
the
represent-creator-and-suffix-state-explicitly
branch
from
October 28, 2026 14:51
f3fdc9b to
588cd43
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## stack/concept-registry/05-translator-integration #1009 +/- ##
===================================================================================
Coverage ? 89.94%
===================================================================================
Files ? 183
Lines ? 6203
Branches ? 1027
===================================================================================
Hits ? 5579
Misses ? 391
Partials ? 233
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Clang-Tidy Check ResultsClang-tidy found the following issue(s) on lines changed by this pull request: |
marcpaterno
force-pushed
the
represent-creator-and-suffix-state-explicitly
branch
2 times, most recently
from
October 28, 2026 16:26
30b106b to
5063d91
Compare
- Model an unqualified creator's plugin and an empty suffix as explicit empty values instead of invalid empty identifiers. - Make a product specification's creator optional; provider construction now requires a present creator. - Reject empty algorithm names, empty plugin components, and an empty configured module_label instead of accepting them silently. - Rename the default source creator from "[Source]" to "phlex_source", which is a valid name under the new parser. - Return borrowed string views from handle creator() and suffix() accessors. - Add tests for parsing, equality/hashing, exact product lookup, provider construction, and handle views.
Represent product suffixes as suffix_t so explicit empty, named, and
omitted selectors are distinct in matching, ordering, and diagnostics.
An omitted suffix matches any product, an empty suffix matches only the
empty product, and a named suffix matches only that name.
- Route the producer catalog, Python wrappers, and FORM labels through
suffix_t text; the persisted FORM layout is unchanged.
- Treat an omitted creator as unrestricted, and require a present creator
when a selector names one.
- Require a type for typed product store lookups, so an untyped "hits"
specification is no longer a wildcard.
- Add tests for selector states, catalog lookup, graph selection, and FORM
suffix persistence, and update existing tests to use empty_string{}.
marcpaterno
force-pushed
the
represent-creator-and-suffix-state-explicitly
branch
from
October 28, 2026 16:38
5063d91 to
74241c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
explicit empty values instead of invalid empty identifiers.
construction now requires a present creator.
configured module_label instead of accepting them silently.
which is a valid name under the new parser.
accessors.
provider construction, and handle views.
Stack created with GitHub Stacks CLI • Give Feedback 💬