Repository navigation
chore(clang-tidy): address findings and suppress false positives - #1021
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
| Layer / File(s) | Summary |
|---|---|
Lint rules and targeted suppressions .clang-tidy, phlex/model/fixed_hierarchy.cpp, test/form/form_basics_test.cpp |
The clang-tidy configuration changes two rules. The source and test code add targeted lint and analyzer suppressions. |
Source declarations and includes form/persistence/persistence_reader.cpp, phlex/core/framework_graph.hpp, plugins/generate_layers.cpp, plugins/python/src/modulewrap.cpp |
The changes remove unused includes and adjust member initialization and local const qualification. |
Test declarations and includes test/accumulator_test.cpp, test/form/cell_number_vector.cpp, test/multilayer_join_test.cpp, test/replicated_test.cpp, test/yielding_driver_test.cpp |
Tests add forward-declaration includes, remove unused includes, and adjust generator and local declarations. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Other
Suggested reviewers: aolivier23, greenc-fnal
Merge Risk: 
611dd
-
The cleanup changes are ready to merge with no identified current-head risk.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely summarizes the pull request. It identifies the clang-tidy focus and the two main change types: addressing findings and suppressing false positives. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 9 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
611dd0b to
15c22c3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1021 +/- ##
==========================================
- Coverage 89.58% 89.58% -0.01%
==========================================
Files 177 177
Lines 6012 6010 -2
Branches 994 994
==========================================
- Hits 5386 5384 -2
Misses 397 397
Partials 229 229
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
15c22c3 to
9675ab0
Compare
Remove unused includes and redundant initialization, add direct declaration includes, and improve const correctness. Disable noisy template virtual-function portability diagnostics and ignore libstdc++ internal headers in include-cleaner. Add targeted suppressions for const-correctness and the sanitizer-checked FORM writer leak false positive.
9675ab0 to
d9e5944
Compare
These PR addresses
clang-tidywarnings that have crept in.portability-template-virtual-member-functioncheck and excludedbits/headers frommisc-include-cleaner.phlex/model/fwd.hppincludes and made the test random-number generator explicitlystatic thread_local.