Skip to content

fwk: lotus: clamp typec_safety_level in update_safety_power_limit() (CPU stuck at ~600 MHz) #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkornreich wants to merge 1 commit into
base: fwk-tulip-29169
Choose a base branch
from
+11 −2
Open

fwk: lotus: clamp typec_safety_level in update_safety_power_limit() (CPU stuck at ~600 MHz) #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions zephyr/program/framework/lotus/src/cpu_power.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,12 +250,21 @@ static int update_safety_power_limit(int active_mpower)
}
break;
case LEVEL_TYPEC_1_5A:
/*
* typec_safety_level indexes safety_table[TYPEC_SAFETY_LEVEL_COUNT]
* in cypd_update_safety_table(), so keep it in [LEVEL_0, LEVEL_3].
* Unclamped, a decrease right after entering this level drove it
* negative: the ladder never stepped back to LEVEL_PROCHOT, so
* THROTTLE_SRC_BAT_DISCHG_CURRENT was never released.
*/
if (level_increase) {
typec_safety_level++;
if (typec_safety_level < TYPEC_SAFETY_LEVEL_3)
typec_safety_level++;
if (typec_safety_level == TYPEC_SAFETY_LEVEL_3)
safety_level++;
} else {
typec_safety_level--;
if (typec_safety_level > TYPEC_SAFETY_LEVEL_0)
typec_safety_level--;
if (typec_safety_level == TYPEC_SAFETY_LEVEL_0)
safety_level--;
}
Expand Down