Repository navigation
refactor(filesystem): Port the upstream archive file system rework - #653
Open
tintinhamans wants to merge 13 commits into
Open
tintinhamans wants to merge 13 commits into
tintinhamans wants to merge 13 commits into
Conversation
This was referenced Oct 24, 2026
…m::openArchiveFile() (TheSuperHackers#3376)
…leSystem, Win32LocalFileSystem (TheSuperHackers#3374)
…ile::getFileInfo(), StdBIGFile::getFileInfo() (TheSuperHackers#3415)
…ystem into BIGFileSystem (TheSuperHackers#3505)
…e loadBigFilesFromDirectory (TheSuperHackers#3505)
…riting archive first
tintinhamans
force-pushed
the
arctic/go/fix/port-archive-filesystem
branch
from
October 28, 2026 01:47
73f827c to
24e01a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #635.
Ports TheSuperHackers#3376, TheSuperHackers#3374, TheSuperHackers#3415, TheSuperHackers#3505 and TheSuperHackers#3588, with the upstream number in each commit title, so the BIG loaders are one
BIGFileSystemand upstream syncs stop conflicting. GO's BIG header hardening and community patch loading are kept. Includes #654, closed as folded into this PR.The TheSuperHackers#3588 commit reads the BIG header whole and checks it. GO main skipped the fourth header field, so a file cut off after the file count loaded as an empty archive. A header or directory that is cut short, a negative file count and a name that does not end are now rejected like a wrong identifier, and the half built archive is deleted.
It also ports TheSuperHackers#3571 and TheSuperHackers#3458, both approved and not merged upstream yet. An archive that overwrites others is placed first with
lower_bound, wherefindon amultimapmay return any of the equal keys.ArchiveFile::getFileListInDirectorylists subdirectories only when asked, as loose files already do.Tested:
z_generalsbuilds.