Repository navigation
[CHA-5933] test: run scheduled message specs unconditionally - #224
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nijeesh-stream
requested review from
JimmyPettersson85,
shaljam and
vishalnarkhede
as code owners
October 28, 2026 12:41
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
chat_scheduled_messages_enabledon, so the scheduled-message specs no longer skip when the feature is disabled; a disabled feature now fails the suite.scheduled_atup to the next whole UTC minute (floor now+1m). The update spec now requests a whole-minute time two hours out, which the server stores unchanged, and asserts exact equality instead ofbe_within(1).🤖 Generated with Claude Code
Note
Low Risk
Test-only changes with no production or library code paths affected.
Overview
Scheduled message integration tests now assume the CI Stream app has scheduled messages enabled:
schedule_or_skipbecomesschedule, and the rescue that skipped on “scheduled messages are not enabled” is removed so a disabled feature fails the suite instead of being skipped.The update scheduled message example aligns with server behavior that stores future
scheduled_aton whole UTC minutes. A newwhole_minute_from_nowhelper picks a timestamp already on a minute boundary, and the assertion switches frombe_within(1)to exact equality onscheduled_at.Spec-only changes in
spec/client_spec.rb; no client library code.Reviewed by Cursor Bugbot for commit e9ee9f0. Bugbot is set up for automated code reviews on this repo. Configure here.