Skip to content

[CHA-5933] test: run scheduled message specs unconditionally - #224

Merged
nijeesh-stream merged 1 commit into
masterfrom
fix/cha-5933-unskip-scheduled-tests
Oct 29, 2026
Merged

nijeesh-stream merged 1 commit into
masterfrom
fix/cha-5933-unskip-scheduled-tests

Conversation

@nijeesh-stream

@nijeesh-stream nijeesh-stream commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

TLDR

  • The CI app (16793) has chat_scheduled_messages_enabled on, so the scheduled-message specs no longer skip when the feature is disabled; a disabled feature now fails the suite.
  • The server rounds a future scheduled_at up to the next whole UTC minute (floor now+1m). The update spec now requests a whole-minute time two hours out, which the server stores unchanged, and asserts exact equality instead of be_within(1).
  • Spec-only change; no library code touched.

🤖 Generated with Claude Code


Note

Low Risk
Test-only changes with no production or library code paths affected.

Overview
Scheduled message integration tests now assume the CI Stream app has scheduled messages enabled: schedule_or_skip becomes schedule, and the rescue that skipped on “scheduled messages are not enabled” is removed so a disabled feature fails the suite instead of being skipped.

The update scheduled message example aligns with server behavior that stores future scheduled_at on whole UTC minutes. A new whole_minute_from_now helper picks a timestamp already on a minute boundary, and the assertion switches from be_within(1) to exact equality on scheduled_at.

Spec-only changes in spec/client_spec.rb; no client library code.

Reviewed by Cursor Bugbot for commit e9ee9f0. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nijeesh-stream
nijeesh-stream merged commit b7352bf into master Oct 29, 2026
10 checks passed
@nijeesh-stream
nijeesh-stream deleted the fix/cha-5933-unskip-scheduled-tests branch October 29, 2026 11:12
@github-actions github-actions Bot mentioned this pull request Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant