Repository navigation
TaskManager: add options to set output compression and auto-flush - #153
Merged
Merged
Conversation
Contributor
Author
|
@lubynets I think this is very useful option to have for large data productions to be able to control and optimize these parameters. Fyi: Before the next tag, I have 2-3 more requests in the pipeline which should go in before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users of
TaskManagercan now choose the compression of the output file and the auto-flush setting of the output tree:SetCompressionSettings(int)— ROOT compression setting (100 × algorithm + level), e.g.505for ZSTD level 5 (ROOT::RCompressionSetting::EDefaults::kUseGeneralPurpose). Also applied to cloned branches inkCopyTreemode, which otherwise keep the compression of the input file.SetAutoFlush(Long64_t)— forwarded toTTree::SetAutoFlush().Default behaviour is unchanged: if the setters are not called, ROOT's compiled default is used (
101= zlib level 1 since ROOT 6.20).Some results from my study using ZSTD
505instead of default zlib101using ROOT 6.32:Read time is the best of three passes over all branches. Other settings were also tested. LZ4 reads fastest but produces slightly larger files. LZMA gives the smallest files but reads 5–9× slower. ZSTD 9 compresses only 1–2 % better than ZSTD 5 at about 3× the write time.
Requirements
ROOT::RCompressionSettingwas introduced in 6.16).505), which is the recommended settingTests
New unit test
TaskManager.CompressionAndAutoFlushchecks the compression of the output file and of all branches, as well as the auto-flush value.