Repository navigation
Add Reset() to Container and EventHeader and add UndefValueDouble - #154
Merged
Merged
Conversation
Contributor
Author
|
@lubynets Also this is a very much needed extensio to cope with the matching in time-based mode. I will also have an update to the matching which I am about to finalize... |
Contributor
|
Hi Frederic, thanks a lot for both developments! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
EventHeaderis not cleared between tree entries. If a converter has nothing to fill for an entry, the values of the previous entry are silently written again. One example is a reconstructed event without a matched MC event.This is a way to clear an object before it is filled again for the next tree entry:
UndefValueDouble(-999.). Until now thedoublefield type (Introduce new field type double #152) had no matching "undefined" value. Maybe to be added?Container::Reset()sets all user-defined fields to "undefined" values:UndefValueDouble,UndefValueFloat,UndefValueInt, andfalsefor booleans.EventHeader::Reset()does the same and also sets the vertex position toUndefValueFloat.Things to keep in mind:
falseis used.Track,Particle,HitandModulekeep their current behaviour (Container::Reset()only touches user-defined fields there).