Repository navigation
Null-terminate label, hint and name strings in manual wrappers - #534
Open
armadavalor wants to merge 1 commit into
Open
armadavalor wants to merge 1 commit into
armadavalor wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hand-written wrappers in
ImGui.Manual.cs/ImGui.Manual.ReadOnlySpan.cs(InputText,InputTextMultiline,InputTextWithHint,InputText(byte[]),Begin) encode the label/hint/name into a buffer ofbyteCount + 1bytes but never write the trailing\0.When the string fits under
Util.StackAllocationSizeLimitthis happens to work becausestackallocmemory is zeroed, but for longer strings the buffer comes fromUtil.Allocate(Marshal.AllocHGlobal), which is uninitialized, so ImGui reads past the end of the label and renders garbage (as shown in the issue).This adds the terminator explicitly after each
Util.GetUtf8call, the same way the generated code already does (native_label[native_label_offset] = 0;). The input text buffers were already cleared withInitBlockUnaligned, so they are unchanged.Built
src/ImGui.NETlocally (0 warnings, 0 errors).Closes #502