Repository navigation
task: coverity - #3070
Merged
Merged
task: coverity#3070
Conversation
jharlow-intel
requested review from
antonwolfy,
ndgrigorian and
vlad-perevezentsev
as code owners
September 15, 2026 13:23
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev16=np2py314h8d9cdd5_24 ran successfully. |
Collaborator
|
Coverage is 82.649% — task/coverity into master. No base build found for |
ndgrigorian
approved these changes
Sep 24, 2026
antonwolfy
reviewed
Sep 25, 2026
Unpinned `cython` resolves to whatever PyPI has that Monday, and a Cython upgrade rewrites the generated C, which shuffles Coverity CIDs and loses their triage. Pin 3.3.0, the version conda-forge currently resolves for the regular builds, matching the mkl_fft and mkl-service scans. Also align the upload-artifact pin with master (v7.0.2).
antonwolfy
reviewed
Oct 23, 2026
The generic clangcc/clangcxx templates parse the SYCL headers without SYCL mode, so most SYCL translation units fail to emit (dpctl's scan with the same setup captures 46%). Register icx/icpx with Coverity's Intel oneAPI compiler type instead, as mkl_umath does, and fail the job when fewer than 85% of C/C++ units are captured so a partial capture does not use up a scan. Drop the _skbuild removal, which is a no-op on a fresh checkout.
The native Intel compiler type emits each SYCL source as a host pass and a spir64 device pass. The Scan build tool cannot parse the device pass, so the overall emit percentage tops out near 50% even when every source is captured. Require every project source to have a completed emit instead, and skip the upload on feature-branch dispatches so they can validate capture without replacing master's results on the dashboard.
antonwolfy
reviewed
Oct 28, 2026
pip already installs ninja. The dpctl comment described a conda/DPC++ RT constraint that does not apply to this job; replace it with the actual ordering constraint from dpctl_pkg.txt's --index-url.
The reasoning lives in IntelPython/dpctl#2401 and this PR's review threads.
antonwolfy
approved these changes
Oct 28, 2026
antonwolfy
left a comment
antonwolfy
left a comment
Contributor
There was a problem hiding this comment.
Thank you @jharlow-intel, no more comments from me
github-actions Bot
added a commit
that referenced
this pull request
Oct 28, 2026
https://scan.coverity.com/projects/intelpython-dpnp?tab=overview --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> b47748b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://scan.coverity.com/projects/intelpython-dpnp?tab=overview
Pretty much the same as the others