Repository navigation
[PostgreSQL] Parse GROUP BY DISTINCT with GROUPING SETS - #2830
Open
2748109647 wants to merge 1 commit into
Open
2748109647 wants to merge 1 commit into
2748109647 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2785
PostgreSQL accepts
GROUP BY DISTINCT GROUPING SETSand usesDISTINCTto remove duplicate grouping sets. The issue includes a valid PostgreSQL query that JSqlParser currently rejects, which is a concrete compatibility use case for parsing PostgreSQL SQL.This change parses the optional modifier and stores it in
GroupByElement, so bothtoString()and the deparser preserve it during round trips. The AST defaults to the existing non-distinct behavior.No performance benchmark was run. The change adds an optional token check in the GROUP BY grammar and a boolean check when deparsing; I am not claiming a measured performance impact.
Validation
mvn -B -ntp '-Dlicense.skipUpdateLicense=true' '-Dtest=SelectTest#testGroupingSetsDistinctIssue2785' test— passed, 1 test.mvn -B -ntp '-Dlicense.skipUpdateLicense=true' '-Dtest=SelectTest' test— passed, 741 tests, 0 failures, 0 errors, 8 skipped.git diff --check— passed.The regression test covers parsing and deparsing; no live PostgreSQL integration test or performance benchmark was run.