Repository navigation
Add unit tests for custom GraphQL directives - #4165
Merged
josephsnyder merged 2 commits intoOct 28, 2026
Merged
josephsnyder merged 2 commits into
josephsnyder merged 2 commits into
Conversation
josephsnyder
approved these changes
Oct 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 28, 2026
Our custom GraphQL directives are currently tested by the `tests/Feature/GraphQL/FilterTest.php` feature test and test cases in other GraphQL type tests. Those tests test basic behavior against a live database, but don't make assertions about the schema changes these directives cause. This PR adds unit tests which more precisely test what these directives actually do.
Member
Author
|
Needs test updates due to a logical conflict the merge queue caught |
williamjallen
force-pushed
the
custom-graphql-directive-unit-tests
branch
from
October 28, 2026 14:37
60fca77 to
25b39e0
Compare
josephsnyder
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our custom GraphQL directives are currently tested by the
tests/Feature/GraphQL/FilterTest.phpfeature test and test cases in other GraphQL type tests. Those tests test basic behavior against a live database, but don't make assertions about the schema changes these directives cause. This PR adds unit tests which more precisely test what these directives actually do.