Repository navigation
Sign project invitation URLs - #4167
Merged
josephsnyder merged 1 commit intoOct 28, 2026
Merged
Conversation
josephsnyder
requested changes
Oct 28, 2026
josephsnyder
left a comment
josephsnyder
left a comment
Member
There was a problem hiding this comment.
The code looks solid but there's a problem with the link in the email. The conversion of the URL into the text of the email escapes the ampersand which breaks the link:
You have been invited by administrator to join PublicDashboard.
Click the link below to join the project. If you did not expect this invitation, you can safely ignore this email.
* http://localhost:8080/projects/2/invitations/3?expires=1793801941&signature=679450564720397b75bed4ea38b0d06451e86d91aa8da09a32ae77febc93ac0c
-CDash
If you replace or delete the escaping, it functions as expected.
Member
Author
|
@josephsnyder That behavior is caused by a broader problem fixed by #4173. Once #4173 is merged, I'll rebase this PR and re-request review. |
We currently use account email matching instead of signed URLs to associate invitations with CDash accounts. Signing invitations is slightly safer because it proves ownership of the inbox.
williamjallen
force-pushed
the
project-invitation-signing
branch
from
October 28, 2026 19:42
3405660 to
3dcc69b
Compare
williamjallen
added a commit
to williamjallen/CDash
that referenced
this pull request
Oct 28, 2026
Our text emails currently escape content as HTML, leading to errors such as the one reported [here](Kitware#4167 (review)). This fixes the issue by eliminating the unnecessary HTML escaping. If we convert to HTML emails in the future, we'll need to re-implement HTML escaping.
josephsnyder
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently use account email matching instead of signed URLs to associate invitations with CDash accounts. Signing invitations is slightly safer because it proves ownership of the inbox.