Repository navigation
Remove legacy CDash catch-all controller - #4175
Open
williamjallen wants to merge 1 commit into
Open
williamjallen wants to merge 1 commit into
williamjallen wants to merge 1 commit into
Conversation
The CDash controller was a fallback route that ran legacy PHP files from `app/cdash/public/api`. All of those endpoints have since moved to Laravel controllers, so it can no longer serve anything. This removes it, along with its catch-all route. It also deletes an unused request to a non-existent `/api/v2 route` in `ProjectPermissions`, which only passed because of the catch-all. Unknown `/api` URLs now get Laravel's standard 404, and wrong-method requests to existing endpoints get a 405 instead of a 404.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CDash controller was a fallback route that ran legacy PHP files from
app/cdash/public/api. All of those endpoints have since moved to Laravel controllers, so it can no longer serve anything. This removes it, along with its catch-all route. It also deletes an unused request to a non-existent/api/v2 routeinProjectPermissions, which only passed because of the catch-all. Unknown/apiURLs now get Laravel's standard 404, and wrong-method requests to existing endpoints get a 405 instead of a 404.