Repository navigation
feat(editor): add a markers prop - #9
Open
jlee-kitware wants to merge 2 commits into
Open
jlee-kitware wants to merge 2 commits into
jlee-kitware wants to merge 2 commits into
Conversation
Applications that run or lint the edited code could report where it
failed only outside the editor. The editor now takes a list of
{line, message, severity} and applies it with setModelMarkers, so the
line is marked and the message appears on hover.
Both clients accept it, and markers set before the editor mounts are
applied once the model exists.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applications that run or lint the edited code could report where it failed only outside the editor. The editor now takes a list of {line, message, severity} and applies it with setModelMarkers, so the line is marked and the message appears on hover.
Both clients accept it, and markers set before the editor mounts are applied once the model exists.
Tests cover the prop binding. The Monaco behavior was verified manually in both clients, since the repo has no JS test setup.