Repository navigation
Add agent instructions, Jacques the sous-chef persona and engineering skills - #46
Merged
Merged
Conversation
Bring AGENTS.md, CLAUDE.md, Sous and the shared skills across from Minimal API, and add the GraphQL presentation skills: expose-a-use-case, api-conventions, dataloaders, schema-snapshot, presentation-integration-tests and nitro. Ship them in the template package, leaving out the repository and maintainer skills. Line the presentation layer up with the skills: register Serilog with AddSerilog and name the version properties without spaces, give every integration test class its own application and database instead of a static one, and drop the Nullable settings that Directory.Build.props already sets.
Contributor
Build Pipeline✅ Ready to merge. Every stage passed.
Commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the agent setup over from Minimal API, so any coding agent works here the way we do.
.agents/agents/jacques.md). These match Minimal API except for the GraphQL rows..agents/skills:expose-a-use-case(a query, mutation or type),api-conventions(naming, nullability, connections and error codes),dataloaders,schema-snapshot,presentation-integration-testsandnitro.A few presentation changes so the skills describe the code as it is:
Presentation.Tests.Unitproject, so every template has the same four test projects. It tests our own code directly:ApplicationErrorFilter(theVALIDATIONandNOT_FOUNDcodes, and errors it leaves alone), the cursor parsing and connection building inPageExtensions, andAuthenticationSettings, which moved over from the integration tests.staticapplication.AddSerilog. The version properties are nowAssemblyVersionandAssemblyInformationalVersion.Nullablesettings thatDirectory.Build.propsalready sets are gone from the presentation projects.The docs site's file trees pick up the new test project in LeanMeanCleanApps/leanmeancleanapps.github.io#10.