Skip to content

Drop dead code, page through PageRequest, and give the version and clock one home each - #39

Merged
stphnwlsh merged 3 commits into
mainfrom
chore/trim-shared-layers
Nov 4, 2026
Merged

stphnwlsh merged 3 commits into
mainfrom
chore/trim-shared-layers

Conversation

@stphnwlsh

@stphnwlsh stphnwlsh commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

A trim of the shared layers after checking them against the original brief. Paging now speaks Application's own types end to end (PageRequest in, Page<T> out). The shared version query gets its VersionInfo from the host rather than rummaging through the entry assembly, so the startup registers one even though no function sends that query yet. The system clock is registered once, in Infrastructure, which owns the outside world. Five mapper methods and a pile of virtual modifiers that nothing used are gone.

The paging, data access, mapping, time provider and mediator skills say the same as the code, and the paging skill now explains who calls the batch review queries and why by-id returns every child.

Related issues

None.

Type of change

  • Bug fix
  • New feature
  • Breaking change (the generated solution or template parameters change in a way existing users will notice)
  • Refactoring or clean-up
  • Documentation
  • Build, pipeline or dependency update

Shared layers

  • This only touches the Presentation layer of this template.
  • This touches the Application or Infrastructure layers, tests, pipeline or repository setup, so it needs to be carried across all five templates.

Checklist

  • dotnet build and dotnet test pass locally with no warnings.
  • I added or updated tests, and line coverage stays at or above 95%.
  • I updated the README or docs where behaviour changed.
  • If this changes how we do something, I updated the matching skill in .agents/skills.
  • I checked the template still installs and creates a working solution (see CONTRIBUTING.md).

@stphnwlsh stphnwlsh self-assigned this Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Build Pipeline

✅ Ready to merge. Every stage passed.

Stage Result Details
Build 🟢 Passed Version 2026.11.04.136-pr-39 · Template package 197 KB
Test 🟢 Passed 180 passed · 0 failed · 0 skipped · Template installs, builds and passes its tests
Coverage 🟢 Passed 100% (650 of 650 lines) · Needs 95%
Static Analysis 🟢 Passed No open CodeQL alerts
Dependency Review 🟢 Passed 0 vulnerable packages · 0 licence problems
Container Scan 🟢 Passed Image starts and answers · 3 open Trivy alerts, none blocking: 1 medium, 1 low, 1 note · 1 ignored in .trivyignore

Commit 78b0393 · Full run

# Conflicts:
#	src/Presentation/LambdaFunction/Startup.cs
@stphnwlsh
stphnwlsh merged commit f8a0b55 into main Nov 4, 2026
13 checks passed
@stphnwlsh
stphnwlsh deleted the chore/trim-shared-layers branch November 4, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant