Repository navigation
Drop dead code, page through PageRequest, and give the version and clock one home each - #39
Merged
Merged
Conversation
Build Pipeline✅ Ready to merge. Every stage passed.
Commit |
# Conflicts: # src/Presentation/LambdaFunction/Startup.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A trim of the shared layers after checking them against the original brief. Paging now speaks Application's own types end to end (
PageRequestin,Page<T>out). The shared version query gets itsVersionInfofrom the host rather than rummaging through the entry assembly, so the startup registers one even though no function sends that query yet. The system clock is registered once, in Infrastructure, which owns the outside world. Five mapper methods and a pile ofvirtualmodifiers that nothing used are gone.The paging, data access, mapping, time provider and mediator skills say the same as the code, and the paging skill now explains who calls the batch review queries and why by-id returns every child.
Related issues
None.
Type of change
Shared layers
Checklist
dotnet buildanddotnet testpass locally with no warnings..agents/skills.