Repository navigation
Add agent instructions, Jacques the sous-chef persona and engineering skills - #36
Merged
Merged
Conversation
Bring AGENTS.md, CLAUDE.md, Sous and the shared skills across from Minimal API, and add the MCP presentation skills: expose-a-use-case, api-conventions, json-serialization, presentation-integration-tests and mcp-inspector. Ship them in the template package, leaving out the repository and maintainer skills. Line the MCP presentation layer up with the skills: register Serilog with AddSerilog and name the version properties without spaces, read test results with the server's own JSON options, always require authorization on /mcp with an allow-all policy when authentication is off, write tool, resource and prompt descriptions as XML comments on partial methods, list only the types the server writes in the JSON context, and drop the CS8618 pragma from the tool tests.
Contributor
Build Pipeline✅ Ready to merge. Every stage passed.
Commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the agent setup over from Minimal API, so any coding agent works here the way we do.
.agents/agents/jacques.md). These match Minimal API except for the MCP rows..agents/skills:expose-a-use-case(a tool, resource or prompt),api-conventions(tool names, annotations, result shapes, errors and server instructions),json-serialization,presentation-integration-tests(a real MCP client against the in-memory server) andmcp-inspector.A few presentation changes so the skills describe the code as it is:
partialmethods. The MCP SDK's generator turns them into the same[Description]attributes, word for word, so XML comments are the documentation here too./mcpalways asks for authorization, the same as Minimal API. When no authority is set, the policy lets everyone in.AddSerilog. The version properties are nowAssemblyVersionandAssemblyInformationalVersion.McpSerializer.Optionsinstead of a private copy.AppJsonSerializerContextlists only the types the server writes.#pragmain the tool tests is gone.