Skip to content

Add agent instructions, Jacques the sous-chef persona and engineering skills - #36

Merged
stphnwlsh merged 8 commits into
mainfrom
feature/agents-and-skills
Nov 3, 2026
Merged

stphnwlsh merged 8 commits into
mainfrom
feature/agents-and-skills

Conversation

@stphnwlsh

@stphnwlsh stphnwlsh commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Brings the agent setup over from Minimal API, so any coding agent works here the way we do.

  • AGENTS.md, a one-line CLAUDE.md and Jacques, our sous-chef persona (.agents/agents/jacques.md). These match Minimal API except for the MCP rows.
  • 37 skills in .agents/skills:
    • 25 shared skills, identical to Minimal API except for the name.
    • 5 MCP skills: expose-a-use-case (a tool, resource or prompt), api-conventions (tool names, annotations, result shapes, errors and server instructions), json-serialization, presentation-integration-tests (a real MCP client against the in-memory server) and mcp-inspector.
    • 7 repository and maintainer skills, which aren't included in the template package.
  • The template package ships AGENTS.md, CLAUDE.md, Jacques and the 30 engineering skills. I installed a packed template, and the generated solution builds and passes its tests.
  • CONTRIBUTING gets the "Working with an AI agent" section, and the PR template gets the skills checkbox.

A few presentation changes so the skills describe the code as it is:

  • Tool, resource and prompt descriptions are now XML comments on partial methods. The MCP SDK's generator turns them into the same [Description] attributes, word for word, so XML comments are the documentation here too.
  • /mcp always asks for authorization, the same as Minimal API. When no authority is set, the policy lets everyone in.
  • Serilog is registered with AddSerilog. The version properties are now AssemblyVersion and AssemblyInformationalVersion.
  • The integration tests read results with the server's own McpSerializer.Options instead of a private copy.
  • AppJsonSerializerContext lists only the types the server writes.
  • The CS8618 #pragma in the tool tests is gone.

Bring AGENTS.md, CLAUDE.md, Sous and the shared skills across from Minimal API, and add the MCP presentation skills: expose-a-use-case, api-conventions, json-serialization, presentation-integration-tests and mcp-inspector. Ship them in the template package, leaving out the repository and maintainer skills.

Line the MCP presentation layer up with the skills: register Serilog with AddSerilog and name the version properties without spaces, read test results with the server's own JSON options, always require authorization on /mcp with an allow-all policy when authentication is off, write tool, resource and prompt descriptions as XML comments on partial methods, list only the types the server writes in the JSON context, and drop the CS8618 pragma from the tool tests.
@stphnwlsh stphnwlsh self-assigned this Nov 2, 2026
@github-actions github-actions Bot added enhancement New feature or request build labels Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Build Pipeline

✅ Ready to merge. Every stage passed.

Stage Result Details
Build 🟢 Passed Version 2026.11.03.142-pr-36 · Template package 199 KB
Test 🟢 Passed 226 passed · 0 failed · 0 skipped · Template installs, builds and passes its tests
Coverage 🟢 Passed 100% (741 of 741 lines) · Needs 95%
Static Analysis 🟢 Passed No open CodeQL alerts
Dependency Review 🟢 Passed 0 vulnerable packages · 0 licence problems
Container Scan 🟢 Passed Image starts and answers · No open Trivy alerts

Commit 5a8d369 · Full run

@stphnwlsh stphnwlsh changed the title Add agent instructions, the Sous persona and engineering skills Add agent instructions, Jacques the sous-chef persona and engineering skills Nov 3, 2026
@stphnwlsh
stphnwlsh merged commit 2f2f160 into main Nov 3, 2026
13 checks passed
@stphnwlsh
stphnwlsh deleted the feature/agents-and-skills branch November 3, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

2 participants