Repository navigation
Add agent instructions, Jacques the sous-chef persona and engineering skills - #39
Merged
Merged
Conversation
Copies AGENTS.md, CLAUDE.md, the Sous persona and the shared and repository skills from CleanMinimalApi, and adds the Web API presentation skills: expose-a-use-case, api-conventions, json-serialization, openapi-and-scalar and presentation-integration-tests. Brings the presentation layer in line with the skills: one UseApiDefaults for both sets of JSON options and the tests (no IgnoreCycles), AddSerilog with AssemblyVersion properties, and ISender injected through the controller constructors.
Contributor
Build Pipeline✅ Ready to merge. Every stage passed.
Commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the agent setup over from Minimal API, so any coding agent works here the way we do.
.agents/agents/jacques.md). These match Minimal API except for the Web API rows..agents/skills:expose-a-use-case(a controller action),api-conventions,json-serialization(both sets of JSON options),openapi-and-scalarandpresentation-integration-tests.A few presentation changes so the skills describe the code as it is:
Presentation.Tests.Unitproject, so every template has the same four test projects. The tests that called our classes directly moved into it from the integration tests: the exception handler, the authentication settings, the bearer security transformer and the JSON options. NSubstitute moved with them.UseApiDefaults()sets the JSON options. The controllers, the HTTP JSON options and the integration tests all use it, so the settings are no longer copied twice.IgnoreCyclesis gone. A new test checks that a number sent as a string gets a400.ISenderthrough the constructor instead of pulling it fromHttpContext.RequestServices. The version action now returnsOk(...)like the others.AddSerilog. The version properties are nowAssemblyVersionandAssemblyInformationalVersion.The docs site's file trees pick up the new test project in LeanMeanCleanApps/leanmeancleanapps.github.io#10.