Repository navigation
Conversation
The DOI link used https://10.4033/... which browsers and curl treat as a private IP address instead of a DOI resolver. Use the canonical https://doi.org/ resolver. Fixes LibraryCarpentry#173.
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Fixes #173. In the "Using bad null values" section, the DOI citation for White et al. links to
https://10.4033/iee.2013.6b.6.f. Because10.4033is inside the private IPv4 range, the browsertreats it as a host address (
10.0.15.193) rather than a DOI, so the link never reaches thearticle.
Reproduction:
curl -sIL https://10.4033/iee.2013.6b.6.ffails with no HTTP response and reportsthe effective URL as
https://10.0.15.193/iee.2013.6b.6.f.Root cause
episodes/02-common-mistakes.md:131uses the bare DOI string as the href instead of the canonicaldoi.orgresolver URL.Fix
Point the existing link at
https://doi.org/10.4033/iee.2013.6b.6.f. The link text and surroundingprose are unchanged.
Verification
curl -sIL https://10.4033/iee.2013.6b.6.f→ no response, resolves tohttps://10.0.15.193/...(before)
curl -sIL https://doi.org/10.4033/iee.2013.6b.6.f→ 200, redirects tohttps://ojs.library.queensu.ca/index.php/IEE/article/view/4608(after)grep -rn "10\.4033" --include=*.md .→ only the correcteddoi.orgURL remainsgit diff --check→ cleansandpaper+ pandoc + thecarpentries/workbench-dockerimage) in CI. R and pandoc are not installed in this environment,so the site build itself could not be run locally; the change is a URL-only edit in Markdown.
Risk / rollback
One URL in one file, no prose or build changes. Reverting the commit restores the previous link.
AI assistance: prepared with an AI coding agent; I reviewed and ran the checks above.