Repository navigation
Fix #3500: preserve input floating-point precision in check_box and t… - #5499
dhrubchatterjee16-lang wants to merge 1 commit into
Conversation
Documentation build overview
10 files changed ·
|
d355a99 to
6a90c4b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5499 +/- ##
========================================
Coverage 93.92% 93.92%
========================================
Files 184 184
Lines 22661 22661
Branches 3223 3223
========================================
Hits 21284 21284
Misses 917 917
Partials 460 460 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
IAlibay
left a comment
There was a problem hiding this comment.
Please fill in the AI disclosure that is in the PR template.
|
Hi @IAlibay , thank you for pointing that out! I have updated the PR description to include the full PR template along with the checklist and AI disclosure. Apologies for omitting the template initially! |
Thank you. Since you replied "yes" to the AI usage, can you please provide details about how you used AI tools for this PR? |
|
Hi @IAlibay, Thank you for following up! I used an AI assistant as an interactive pair-programming and debugging aid for this contribution. Specifically:
The code changes themselves are minimal and targeted (adding the optional Please let me know if you would like me to adjust anything! |
6a90c4b to
4d59c2c
Compare
|
Hi @IAlibay, I have rebased this branch onto the latest The full PR template, checklist, and AI disclosure have been updated in the PR description as discussed. All tests are passing locally. Please let me know if you would like me to adjust anything else! |
Fixes #3500
Changes made in this Pull Request:
dtypekeyword argument toMDAnalysis.lib.mdamath.check_box(defaults toNonewhich preserves the input box's dtype).MDAnalysis.lib.mdamath.triclinic_vectorsto acceptdtype=Noneand preserve the input box dtype when converting to box vectors.MDAnalysisTests.lib.test_mdamathtesting float32, float64, and custom dtype preservation.package/CHANGELOGandpackage/AUTHORS.LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: yes
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.