[KristjanESPERANTO]

Previously, an error while initializing or setting up a module's node_helper could abort MagicMirror's startup. This is especially unfortunate when the mirror starts unattended: one failing module can leave the display blank.

With this change, the failing helper is logged and skipped, while the other modules can still start. This makes startup more robust, but it also means a problem might go unnoticed for longer, since everything may appear to work at a glance even though one module has failed.

I personally think the added robustness is worth it, but I’d be glad to hear if you see it differently. Perhaps we can treat this PR as a proof of concept and use it to discuss whether this is the right behavior for us.

I also considered adding an option such as failFast, so users could choose whether a node_helper failure should abort startup.

[sdetweil]

I agree, a failure should not stop mirror from starting
We have a general problem with notifying someone.

[khassel]

That works for me, too.

I also don’t think we should complicate the setup by adding a failFast parameter.

If someone doesn’t notice when a module is missing, then it doesn’t really matter anyway...

It’s in the logs, after all.

@KristjanESPERANTO let me know whether you want to wait for further opinions or if I can go ahead and merge ...

[KristjanESPERANTO]

Oh, thanks for the quick positive feedback! 😃 Since you both gave it a thumbs-up, I'm in favor of merging it.