Repository navigation
refactor(server): migrate server and vendor to ESM - #4321
Merged
khassel merged 1 commit intoOct 28, 2026
Merged
Conversation
khassel
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4316.
I've converted
server.jsandvendor.jsto ESM. I did them together because the server is the only place on the Node side that usesvendor. The browser loader just imports the renamed file.For the e2e tests I added a small
global-setup.mjswrapper, so ESM specs can import the helpers without touching the existing ones.vendor_spec.jsis the first spec using it. The old specs work as before. Importingglobal-setup.jsdirectly doesn't work, because then Vitest would run the app inside its own module loader.