Repository navigation
CH-300 feat: Upgrade Argo to 3.7.18 - #885
Closed
afonsobspinto wants to merge 2 commits into
Closed
afonsobspinto wants to merge 2 commits into
afonsobspinto wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #886 on
feature/CH-300. The replacement preserves this PR's file contents and uses CH-300 commit messages.Closes https://metacell.atlassian.net/browse/CH-300
Supports MNP #1452 / NGLASS-2330.
Changes
Upgrade the vendored Argo controller, server, executor and eight official CRDs from 3.1.15 to 3.7.18. Use Emissary, remove obsolete runtime-selection/pod-worker configuration, update component/executor RBAC, and preserve
POD_NAMES=v1so existing CloudHarness log lookup continues working. Controller and server now render this from a sharedpodNameVersionvalue independently ofextraEnv, with duplicate legacy entries filtered out.This PR is independent of CloudHarness #879, which remains limited to the optional custom exit-handler command. Neither PR includes the other's implementation, and they can be merged separately. MNP ingestion needs both.
Compatibility and rollout
Public methods, caller inputs, API endpoints/response shapes and argo-workflows==5.0.0 remain unchanged. No progress endpoint or listener is introduced; consumers read native node progress through the existing SDK.
The internal compatibility fix converts integer pod-GC delay seconds to Argo duration strings, e.g.
86400→"86400s". Argo 3.7 otherwise rejects existing numeric payloads with HTTP 400. Caller dictionaries are copied; integer TTLs, string durations and SDK-model inputs stay supported. Workflows omit empty image-pull-secret references when no registry secret is configured.Emissary can resolve default task commands using the configured registry credentials. A dedicated namespaced Role/RoleBinding grants the actual controller service account
getaccess only toregistry.secret.name, including when a custom controller account or a cluster-scoped controller is selected.Rebuild and deploy workflow-submitting application images with this serialization fix before upgrading Argo. Then finish active workflows, explicitly upgrade the CRDs (Helm does not upgrade existing CRDs), deploy controller/server/executor together and update downstream image pins. See the upgrade README.
Validation
e44bc7a.The MNP local report records the integration coverage and pending authenticated backoffice rerun.