Repository navigation
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
- Rebuild scrubbed DOMExceptions so OTel span finalization cannot throw on abort - Scrub only credential values of at least eight characters - Own the settingSources default in the Claude adapter, not the runner - Collapse the Pi SDK version to one constant and drop dead resolveBridgeSdkVersion - Add an explicit hostRoot to bridge runtime descriptors - Unify on-success cleanup: keep the container unless the run completed successfully - Wrap runtime file copies in Docker error handling; write missing JSDoc
- Cover the credential scrubber sort comparator with an explicit multi-value test: it previously only ran when the ambient environment contained two or more credential-like variables, which is true on developer machines but not on CI runners, dropping functions coverage to 97.97% and failing the 98.31% threshold. - Cover the Claude adapter getRunMetadata used for telemetry. - Require toolCall input presence when validating pi bridge messages so consumers never see ToolCall objects without their required field. - Document that runAgent/judge signal cancellation is pi-only.
|
Dependency security triage for the new direct dependency
@SocketSecurity ignore npm/@earendil-works/pi-coding-agent@0.83.0 |
|
Superseded by #29 — the branch now lives in MetaMask/agent-runner directly. |
Summary
Adds an optional pi Agent SDK adapter for isolated LiteLLM coding and evaluation runs, using #25 as a reference.
createPiAdapter().Pi runs are LiteLLM-only, use fresh in-memory sessions, and do not discover local settings, extensions, skills, or context files. Unsupported Claude permission options fail explicitly. Persistence, resume, custom tools, and native pi providers/OAuth are out of scope.
Validation
yarn build,yarn typecheck,yarn lint, andyarn testpass.Coverage auto-update is disabled so tests no longer modify the working tree.
Review notes
Dependency security review is still required. This PR does not waive Socket alerts or enable dependency install scripts.