Repository navigation
Conversation
## Description Remediates a credential-handling bug (CWE-522) in the Pi adapter runtime (`agent-runner`). Previously, `createSession` verified that `process.env.LITELLM_API_KEY` was populated but registered the provider using the literal string `'$LITELLM_API_KEY'`. Consequently, all outgoing LiteLLM requests sent `Authorization: Bearer $LITELLM_API_KEY`, causing silent upstream authentication failures while masking the configuration defect. ## Key Changes & Remediations * **Provider Key Resolution (`src/adapters/pi/pi-runtime.ts`)**: - Replaced the string literal `'$LITELLM_API_KEY'` with the actual runtime environment value `process.env.LITELLM_API_KEY`. ## Verification - Validated syntax stripping: ```bash node --experimental-strip-types --check src/adapters/pi/pi-runtime.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remediates a credential-handling bug (CWE-522) in the Pi adapter runtime (
agent-runner).Previously,
createSessionverified thatprocess.env.LITELLM_API_KEYwas populated but registered the provider using the literal string'$LITELLM_API_KEY'. Consequently, all outgoing LiteLLM requests sentAuthorization: Bearer $LITELLM_API_KEY, causing silent upstream authentication failures while masking the configuration defect.Key Changes & Remediations
src/adapters/pi/pi-runtime.ts):'$LITELLM_API_KEY'with the actual runtime environment valueprocess.env.LITELLM_API_KEY.Verification
Confirmed absence of literal $LITELLM_API_KEY key assignment in provider registration.