Skip to content

fix: Clearer error when the model can't be downloaded from the Hub - #319

Merged
Pringled merged 4 commits into
mainfrom
fix/model-download-error
Oct 29, 2026
Merged

Pringled merged 4 commits into
mainfrom
fix/model-download-error

Conversation

@Pringled

Copy link
Copy Markdown
Member

This PR makes semble raise a clearer error when the embedding model can't be downloaded from the Hugging Face Hub, for example because the network blocks Huggingface. The error now names the model and host, says the download is one-time and cached, and points to SEMBLE_MODEL_NAME for using a local path. This resolves #318.

@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/semble/index/dense.py 100.00% <100.00%> (ø)
src/semble/version.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The change reaches workflows that load models for indexes.

The PR appears safe to merge, with a non-blocking test improvement.

Reviews (1) · Last reviewed commit: "chore: Bump version to 0.7.1" · Reviewed by Greptile

Comment thread tests/test_search.py Resolved
@Pringled
Pringled requested a review from stephantul October 29, 2026 06:56
@Pringled
Pringled merged commit 4633ee7 into main Oct 29, 2026
17 checks passed
@Pringled
Pringled deleted the fix/model-download-error branch October 29, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error message is not helpful if huggingface is blocked on a network.

2 participants