Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When MO2 runs Cyberpunk from the command line or a desktop shortcut while MO2 is closed (
run -eormoshortcut://), it never opens its main window, so_on_user_interface_initializednever sets_parentWidget. If the game then exits with a nonzero code,_onFinishedRunraises:This change defaults
_parentWidgettoNoneand skips the crash message when it'sNone. In these runs MO2 exits as soon as the game ends, so the message couldn't stay open anyway. Runs from MO2's window are unchanged.Tested on MO2 2.5.2 with Cyberpunk 2077 2.5 (Steam), ending the game with
taskkill /F(exit code 1):run -e, MO2 closedmoshortcut://, MO2 closedruff check,ruff format --check, andpyrightpass.